[RMS] Elevation Generation fails sometimes when player lands are the same base elevation (or higher)

[Deathcounter]

GAME INFORMATION

^{These details are CRITICAL; DO NOT skip them or your issue may not be reviewed.}

• **GAME BUILD #: Version 101.103.48086.0 (#179158) 23767045 as per main menu
• GAME PLATFORM: Steam
• OPERATING SYSTEM: Windows 10

ISSUE EXPERIENCED

^{DESCRIBE THE ISSUE IN DETAIL (below). LIMIT TO ONE BUG PER THREAD.}

Elevation generation fails to place elevation entirely, or generates it all on the south east edge of the border

FREQUENCY OF ISSUE

^{How often does the issue occur? CHOSE ONE; DELETE THE REST!}

• 25% of the time / matches I play (SOMETIMES)

REPRODUCTION STEPS

^{List CLEAR and DETAILED STEPS we can take to reproduce the issue ourselves… Be descriptive!}

Take my RMS script:
Ditch.txt (21.8 KB)
change the file ending to .rms (you should probably allow your website to upload .rms files)

Here’s the steps to reproduce the issue:

1. Go to scenario editor, create a fresh scenario so it has default settings (mapsize tiny, 2 players)
2. Get a feeling on how a normal map is supposed to look by generating a few instances (you might run into bugged gens eventually) But if you don’t - here are two (different!) failed generations:
3. Generate the map with the seed
   -1561582801:
   
   
   
   Map files to generate elevation on all the grass and instead produces elevation 3 instead of 4 as it was advised to do so in the script (and does in like 80% of maps)
4. Generate the map with the seed
   -1185339459
   
   
   
   As you can see, all the elevation only spawns on the south east edge, this behavior is consistent and occours from time to time

EXPECTED RESULT

^{What was SUPPOSED to happen if the bug you encountered were not present?}

Normal map generation 100% of the time

IMAGE

^{ALWAYS attach a PICTURE (.jpg, .png, .gif) or VIDEO (.mp4, YouTube link) that highlights the problem.}

Despite numerous create elevations that would certainly fill out the entire map, multiple times over, the elevation generation fails to generate.

Theory: I think this has to do with the player lands blocking some sort of connections between the to be elevated lands or that the connection already has elevation, somehow making the game think that part of the map is already “sufficently elevated” (even tho bug still occours without enable_balanced_elevation) and somehow only picks the two remaining quadrants on the south and east part of the map.

The problem is solved if I: Lower the player lands base elevation by -1 elevation compared to the base 100% elevation I set (in this case 3), or reduce the size of the player lands, stopping the “blocking”. Problem persists regardless of create_elevation order

[Deathcounter]

Also while you are on it. Could you have a look at these 1x1 elevation holes (I highlighted them with dirt on the minimap - on a normal generation) surrounding the neutral player lands? They occour because of the spacing declared in the elevation generation having a weird interaction with player lands with the same elevation as well.
Tho I might turn them into a nice looking feature in this map sooo… backwards compatibility? new attribute “elevation_behavior 0” maybe?

Also you probably know already that set_circular_base with base_elevation in Land_Generation doesn’t work as intended right? Cause everyone in the RMS community (including Chrazini) knows about this afaik.